tustvold commented on code in PR #3036:
URL: https://github.com/apache/arrow-rs/pull/3036#discussion_r1015009172


##########
parquet/src/encodings/rle.rs:
##########
@@ -509,6 +514,12 @@ impl RleDecoder {
         let bit_reader = self.bit_reader.as_mut().expect("bit_reader should be 
set");
 
         if let Some(indicator_value) = bit_reader.get_vlq_int() {
+            // fastparquet adds padding to the end of pages. This is not 
spec-compliant

Review Comment:
   Looking at the fastparquet code, the bitpacking logic appears like it would 
pad to 4-byte boundaries as a consequence of it using a 32-bit accumulator
   
   https://github.com/dask/fastparquet/blob/main/fastparquet/cencoding.pyx#L277



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to