alamb commented on code in PR #4107:
URL: https://github.com/apache/arrow-datafusion/pull/4107#discussion_r1015844808
##########
datafusion/sql/src/planner.rs:
##########
@@ -2808,105 +2918,6 @@ fn extract_possible_join_keys(
}
}
-/// Convert SQL simple data type to relational representation of data type
-pub fn convert_simple_data_type(sql_type: &SQLDataType) -> Result<DataType> {
- match sql_type {
- SQLDataType::Boolean => Ok(DataType::Boolean),
- SQLDataType::TinyInt(_) => Ok(DataType::Int8),
- SQLDataType::SmallInt(_) => Ok(DataType::Int16),
- SQLDataType::Int(_) | SQLDataType::Integer(_) => Ok(DataType::Int32),
- SQLDataType::BigInt(_) => Ok(DataType::Int64),
- SQLDataType::UnsignedTinyInt(_) => Ok(DataType::UInt8),
- SQLDataType::UnsignedSmallInt(_) => Ok(DataType::UInt16),
- SQLDataType::UnsignedInt(_) | SQLDataType::UnsignedInteger(_) => {
- Ok(DataType::UInt32)
- }
Review Comment:
I marked the PR as "API change"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
