andygrove commented on code in PR #4136:
URL: https://github.com/apache/arrow-datafusion/pull/4136#discussion_r1016725224


##########
benchmarks/Cargo.toml:
##########
@@ -34,21 +34,21 @@ snmalloc = ["snmalloc-rs"]
 
 [dependencies]
 arrow = "26.0.0"
-datafusion = { path = "../datafusion/core" }
+datafusion = { path = "../datafusion/core", version = "14.0.0" }
 env_logger = "0.9"
 futures = "0.3"
 mimalloc = { version = "0.1", optional = true, default-features = false }
 num_cpus = "1.13.0"
 object_store = "0.5.0"
 parquet = "26.0.0"
-parquet-test-utils = { path = "../parquet-test-utils/" }
+parquet-test-utils = { path = "../parquet-test-utils/", version = "0.1.0" }

Review Comment:
   Another issue is that we don't publish `parquet-test-utils` so we still 
can't publish this crate. This dependency is used in the 
`parquet_filter_pushdown` benchmark and not in `tpch`. I wonder if we should 
consider re-organizing these benchmarks into individual crates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to