thinkharderdev commented on code in PR #504:
URL: https://github.com/apache/arrow-ballista/pull/504#discussion_r1016761799
##########
ballista/scheduler/src/state/task_manager.rs:
##########
@@ -405,19 +478,19 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> TaskManager<T, U>
]
};
- let _res = if let Some(graph) =
self.remove_active_execution_graph(job_id).await {
+ if let Some(graph) = self.remove_active_execution_graph(job_id).await {
let mut graph = graph.write().await;
let previous_status = graph.status();
graph.fail_job(failure_reason);
- let value = self.encode_execution_graph(graph.clone())?;
+
+ let value = encode_protobuf(&graph.status())?;
Review Comment:
First bug uncovered while testing the event loop proper :) When a job would
fail we would save the entire graph into `FailedJobs` here but in all other
scenarios we only save the status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
