jorisvandenbossche commented on code in PR #14599:
URL: https://github.com/apache/arrow/pull/14599#discussion_r1016815088


##########
docs/source/python/filesystems.rst:
##########
@@ -178,11 +179,31 @@ Example how you can read contents from a S3 bucket::
    >>> f.readall()
    b'some data'
 
+
+Note that it is important to configure :class:`S3FileSystem` with the correct
+region for the bucket being used. If `region` is not set, the AWS SDK will
+choose a value, defaulting to 'us-east-1' if the SDK version is <1.8.
+Otherwise it'll try to use a variety of heuristics to resolve the region.

Review Comment:
   I would maybe add the "(environment variables, configuration profile, EC2 
metadata server)" (copied from the C++ source), to make it clear that the 
"heuristics" don't include "infer it from the region"
   
   ```suggestion
   Otherwise it will try to use a variety of heuristics to resolve the region.
   ```



##########
docs/source/python/filesystems.rst:
##########
@@ -178,11 +179,31 @@ Example how you can read contents from a S3 bucket::
    >>> f.readall()
    b'some data'
 
+
+Note that it is important to configure :class:`S3FileSystem` with the correct
+region for the bucket being used. If `region` is not set, the AWS SDK will
+choose a value, defaulting to 'us-east-1' if the SDK version is <1.8.
+Otherwise it'll try to use a variety of heuristics to resolve the region.
+
+It is also possible to resolve the region for :class:`S3FileSystem` by using

Review Comment:
   ```suggestion
   It is also possible to resolve the region from the bucker name for 
:class:`S3FileSystem` by using
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to