viirya commented on code in PR #4145:
URL: https://github.com/apache/arrow-datafusion/pull/4145#discussion_r1016921924
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -32,25 +32,40 @@ use datafusion_expr::{
};
use std::sync::Arc;
-/// The rule can be used to the numeric binary comparison with literal expr,
like below pattern:
-/// `cast(left_expr as data_type) comparison_op literal_expr` or `literal_expr
comparison_op cast(right_expr as data_type)`.
-/// The data type of two sides must be equal, and must be signed numeric type
now, and will support more data type later.
+/// [`UnwrapCastInComparison`] Attempts to remove casts from
Review Comment:
Attempts -> attempts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
