emkornfield commented on PR #14592: URL: https://github.com/apache/arrow/pull/14592#issuecomment-1307637308
> Is this something that can happen due to bad user input? Or are you simply checking for internal invariants? A little bit of both. The only one as far as I can determine that would be a function of bad parquet files is the overflow when down-casting. But I think there are other safe guard in place here. In terms of bad user input, if we are talking about code that consumes these libraries I think most of the places do the negative checks are guards against here (the one exception being PathWriter), which I believe is completely internal. These were raised by another team doing a code audit and "yellow flags". If any of them strike you as superfluous I can revert them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
