westonpace commented on code in PR #14225:
URL: https://github.com/apache/arrow/pull/14225#discussion_r1017154270


##########
cpp/src/arrow/buffer_builder.h:
##########
@@ -198,6 +203,7 @@ class ARROW_EXPORT BufferBuilder {
   uint8_t* data_;
   int64_t capacity_;
   int64_t size_;
+  int64_t alignment_;

Review Comment:
   It took me a minute to think this one through, default move assignment isn't 
allowed because it would boil down to...
   
   ```
   BufferBuilder& BufferBuilder(BufferBuilder&& other) {
     // ...
     // Not allowed
     this->alignment_ = std::move(other.alignment_);
     // ...
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to