tustvold commented on code in PR #3016:
URL: https://github.com/apache/arrow-rs/pull/3016#discussion_r1017483596
##########
arrow-cast/src/cast.rs:
##########
@@ -527,6 +534,16 @@ fn make_timestamp_array(
}
}
+fn as_time_res<T: ArrowPrimitiveType>(v: i64) -> Result<NaiveTime, ArrowError>
{
+ match as_time::<T>(v) {
Review Comment:
This doesn't correctly handle timezones, I think either we should only match
None for now, or we need to use
https://docs.rs/arrow/latest/arrow/temporal_conversions/fn.as_datetime_with_timezone.html
where there is a timezone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
