tustvold commented on code in PR #3056:
URL: https://github.com/apache/arrow-rs/pull/3056#discussion_r1017672545
##########
arrow/src/row/fixed.rs:
##########
@@ -326,9 +326,20 @@ fn decode_fixed<T: FixedLengthEncoding + ToByteSlice>(
pub fn decode_primitive<T: ArrowPrimitiveType>(
rows: &mut [&[u8]],
options: SortOptions,
+ data_type: &DataType,
Review Comment:
This is technically unsafe as it could allow for transmute from decimal128
to decimal256, etc... I have a PR in the works to fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
