yahoNanJing commented on code in PR #4122:
URL: https://github.com/apache/arrow-datafusion/pull/4122#discussion_r1017769925
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -965,32 +934,10 @@ impl DefaultPhysicalPlanner {
if session_state.config.target_partitions > 1
&& session_state.config.repartition_joins
{
- let (left_expr, right_expr) = join_on
- .iter()
- .map(|(l, r)| {
- (
- Arc::new(l.clone()) as Arc<dyn
PhysicalExpr>,
- Arc::new(r.clone()) as Arc<dyn
PhysicalExpr>,
- )
- })
- .unzip();
-
// Use hash partition by default to parallelize hash
joins
Ok(Arc::new(HashJoinExec::try_new(
- Arc::new(RepartitionExec::try_new(
Review Comment:
Very excellent refactoring. Now the `RepartitionExec` will be added by the
`BasicEnforcement` optimization rule rather than be added manually for some
specific operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
