jorisvandenbossche commented on code in PR #14495:
URL: https://github.com/apache/arrow/pull/14495#discussion_r1017886879
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -1019,13 +1020,16 @@ Result<std::unique_ptr<substrait::Expression>> ToProto(
if (call->function_name == "struct_field") {
// catch the special case of calls convertible to a StructField
+ const auto& field_options =
+ checked_cast<const compute::StructFieldOptions&>(*call->options);
+ const DataType& struct_type = *call->arguments[0].type();
+ DCHECK_EQ(struct_type.id(), Type::STRUCT);
Review Comment:
It might be possible to assume here that `field_ref` consists of a FieldPath
with indices already, and then the FindOne and struct type are not needed, and
this should also work for a union
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
