milesgranger commented on code in PR #14495:
URL: https://github.com/apache/arrow/pull/14495#discussion_r1018018178
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2692,14 +2692,32 @@ def test_struct_fields_options():
c = pa.StructArray.from_arrays([a, b], ["a", "b"])
arr = pa.StructArray.from_arrays([a, c], ["a", "c"])
- assert pc.struct_field(arr,
- indices=[1, 1]) == pa.array(["bar", None, ""])
- assert pc.struct_field(arr, [1, 1]) == pa.array(["bar", None, ""])
- assert pc.struct_field(arr, [0]) == pa.array([4, 5, 6], type=pa.int64())
+ assert pc.struct_field(arr, '.c.b') == b
+ assert pc.struct_field(arr, b'.c.b') == b
+ assert pc.struct_field(arr, ['c', 'b']) == b
+ assert pc.struct_field(arr, [1, 'b']) == b
+ assert pc.struct_field(arr, (b'c', 'b')) == b
+ assert pc.struct_field(arr, pc.field(('c', 'b'))) == b
+
+ assert pc.struct_field(arr, '.a') == a
+ assert pc.struct_field(arr, ['a']) == a
+ assert pc.struct_field(arr, 'a') == a
+ assert pc.struct_field(arr, pc.field(('a',))) == a
+
+ assert pc.struct_field(arr, indices=[1, 1]) == b
+ assert pc.struct_field(arr, (1, 1)) == b
+ assert pc.struct_field(arr, [0]) == a
assert pc.struct_field(arr, []) == arr
- with pytest.raises(TypeError, match="an integer is required"):
- pc.struct_field(arr, indices=['a'])
+ with pytest.raises(pa.ArrowInvalid, match="No match for FieldRef*"):
Review Comment:
ah, thought it was glob pattern for some reason, thanks.
https://github.com/apache/arrow/pull/14495/commits/ec4023b551448ed6aa0c0ccccd4311c7a1a87618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
