alamb commented on code in PR #4131:
URL: https://github.com/apache/arrow-datafusion/pull/4131#discussion_r1018221078
##########
benchmarks/src/bin/parquet_filter_pushdown.rs:
##########
@@ -73,7 +74,19 @@ async fn main() -> Result<()> {
let path = opt.path.join("logs.parquet");
- let test_file = gen_data(path, opt.scale_factor, opt.page_size,
opt.row_group_size)?;
+ let mut props_builder = WriterProperties::builder();
+
+ if let Some(s) = opt.page_size {
+ props_builder = props_builder
+ .set_data_pagesize_limit(s)
+ .set_write_batch_size(s);
Review Comment:
👍 I filed https://github.com/apache/arrow-rs/pull/3068 to try and make the
comments somewhat clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
