alamb commented on code in PR #4148:
URL: https://github.com/apache/arrow-datafusion/pull/4148#discussion_r1018287294
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -783,6 +835,105 @@ mod tests {
);
}
+ #[test]
+ fn test_try_cast_to_type_timestamps() {
+ for time_unit in [
+ TimeUnit::Second,
+ TimeUnit::Millisecond,
+ TimeUnit::Microsecond,
+ TimeUnit::Nanosecond,
+ ] {
+ let utc = Some("+0:00".to_string());
+ // No timezone, utc timezone
+ let (lit_tz_none, lit_tz_utc) = match time_unit {
+ TimeUnit::Second => (
+ ScalarValue::TimestampSecond(Some(12345), None),
+ ScalarValue::TimestampSecond(Some(12345), utc),
+ ),
+
+ TimeUnit::Millisecond => (
+ ScalarValue::TimestampMillisecond(Some(12345), None),
+ ScalarValue::TimestampMillisecond(Some(12345), utc),
+ ),
+
+ TimeUnit::Microsecond => (
+ ScalarValue::TimestampMicrosecond(Some(12345), None),
+ ScalarValue::TimestampMicrosecond(Some(12345), utc),
+ ),
+
+ TimeUnit::Nanosecond => (
+ ScalarValue::TimestampNanosecond(Some(12345), None),
+ ScalarValue::TimestampNanosecond(Some(12345), utc),
+ ),
+ };
+
+ // Note that datafusion ignores timezones for comparisons
Review Comment:
```suggestion
// Datafusion ignores timezones for comparisons of ScalarValue
// so double check it here
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
