waitingkuo commented on code in PR #3072:
URL: https://github.com/apache/arrow-rs/pull/3072#discussion_r1018585411
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -1347,7 +1389,39 @@ mod tests {
])
.with_timezone("+08:00".to_string());
assert_eq!(
- "PrimitiveArray<Timestamp(Millisecond, Some(\"+08:00\"))>\n[\n
2018-12-31T00:00:00,\n 2018-12-31T00:00:00,\n 1921-01-02T00:00:00,\n]",
+ "PrimitiveArray<Timestamp(Millisecond, Some(\"+08:00\"))>\n[\n
2018-12-31T08:00:00+08:00,\n 2018-12-31T08:00:00+08:00,\n
1921-01-02T08:00:00+08:00,\n]",
+ format!("{:?}", arr)
+ );
+ }
+
+ #[test]
+ fn test_timestamp_with_incorrect_tz_fmt_debug() {
+ let arr: PrimitiveArray<TimestampMillisecondType> =
+ TimestampMillisecondArray::from(vec![
+ 1546214400000,
+ 1546214400000,
+ -1546214400000,
+ ])
+ .with_timezone("xxx".to_string());
+ assert_eq!(
+ "PrimitiveArray<Timestamp(Millisecond, Some(\"xxx\"))>\n[\n
2018-12-31T00:00:00 (Unknown Time Zone 'xxx'),\n 2018-12-31T00:00:00 (Unknown
Time Zone 'xxx'),\n 1921-01-02T00:00:00 (Unknown Time Zone 'xxx'),\n]",
+ format!("{:?}", arr)
+ );
+ }
+
+ #[test]
+ #[cfg(feature = "chrono-tz")]
+ fn test_timestamp_with_tz_with_daylight_saving_fmt_debug() {
+ let arr: PrimitiveArray<TimestampMillisecondType> =
+ TimestampMillisecondArray::from(vec![
+ 1647161999000,
+ 1647162000000,
+ 1667717999000,
+ 1667718000000,
+ ])
+ .with_timezone("America/Denver".to_string());
+ assert_eq!(
+ "PrimitiveArray<Timestamp(Millisecond,
Some(\"America/Denver\"))>\n[\n 2022-03-13T01:59:59-07:00,\n
2022-03-13T03:00:00-06:00,\n 2022-11-06T00:59:59-06:00,\n
2022-11-06T01:00:00-06:00,\n]",
format!("{:?}", arr)
Review Comment:
add these test cases to timezone with daylight saving
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
