Jimexist commented on PR #3057: URL: https://github.com/apache/arrow-rs/pull/3057#issuecomment-1309717710
turns out i had to make the sbbf module public to make the clippy happy but either way i am going to make use of it soon later and then maybe change it to crate private? one thing that has been bothering me is the fact that down the lane, `RowGroupReader`, `PageReader`, etc. all make use of the trait `ChunkReader` which requires both an offset and a length to do actual IO. For bloom filter it is different: it only contains an offset, then the length of its record is read out from the `BloomFilterHeader`, with only an offset, there's no way to read with `ChunkReader`. I'd probably need to setup a separate trait for this purpose... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
