avantgardnerio commented on code in PR #501:
URL: https://github.com/apache/arrow-ballista/pull/501#discussion_r1018628617
##########
ballista-cli/Cargo.toml:
##########
@@ -29,12 +29,12 @@ rust-version = "1.59"
readme = "README.md"
[dependencies]
-ballista = { path = "../ballista/client", version = "0.9.0", features = [
- "standalone",
-] }
+ballista = { path = "../ballista/client", version = "0.9.0", features =
["standalone"] }
+ballista-core = { path = "../ballista/core", version = "0.9.0" }
clap = { version = "3", features = ["derive", "cargo"] }
-datafusion = "14.0.0"
-datafusion-cli = "14.0.0"
+dashmap = "5.4.0"
+datafusion = { git = "https://github.com/apache/arrow-datafusion.git";, rev =
"7b5842b91ebd00a2c7f894fcad797bea68a56d0f" }
Review Comment:
I see we have done the git-ref thing in the past, so there's precedent.
For FlightSql in particular, I've had to wait a long time for arrow to
release, then datafusion, then ballista. I've been rebasing changes for months
and our fork continues to have changes that are still waiting (in this case on
delta-rs, but now they are way behind datafusion).
For these reasons, I'd strongly prefer to do a ballista release shortly
after the datafusion release, but then go back to git-ref tracking, so we can
keep PRs flowing.
Just my $0.02
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
