zhztheplayer commented on code in PR #14506: URL: https://github.com/apache/arrow/pull/14506#discussion_r1019424214
########## java/c/src/main/java/org/apache/arrow/c/ReferenceCountedArrowArray.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.c; + +import java.util.concurrent.atomic.AtomicInteger; + +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.memory.ForeignAllocationManager; + +/** + * The owner of an imported C Data Interface array. + * + * <p>There is a fundamental mismatch here between memory allocation schemes: AllocationManager represents a single + * allocation (= a single address and length). But an ArrowArray combines multiple allocations behind a single + * deallocation callback. This class bridges the two by tracking a reference count, so that the single callback Review Comment: > But an ArrowArray combines multiple allocations behind a single deallocation callback. Wasn't the deallocation of an ArrowArray always follow the postorder-traversal of the array tree? Or maybe I just got something wrong about the deallocation process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
