alamb commented on PR #4168: URL: https://github.com/apache/arrow-datafusion/pull/4168#issuecomment-1311077088
> However, I was confused with PR sizes. While we discussed implementation in the issue, @alamb also https://github.com/apache/arrow-datafusion/issues/3152#issuecomment-1292654025 that these PRs should be small ( but he suggested a few functions unlike my one function per PR). Rather than implementing one function at one PR, it seems better to implement 3-5 (or more) functions for a PR. My next PRs will include more function implementation. Yeah there is no specific rule here. Basically I have found the smaller your PRs the easier it will be to find enough someone with enough contiguous time to review them. For larger PRs (e.g. 500+ lines) I often need to spend 30-60 minutes to properly review them and finding blocks of time like that for me is much harder than finding 5-10 minutes for smaller PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
