tustvold commented on code in PR #3054:
URL: https://github.com/apache/arrow-rs/pull/3054#discussion_r1019762933
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -129,17 +129,29 @@ impl FixedSizeBinaryArray {
/// # Errors
///
/// Returns error if argument has length zero, or sizes of nested slices
don't match.
- pub fn try_from_sparse_iter<T, U>(mut iter: T) -> Result<Self, ArrowError>
+ pub fn try_from_sparse_iter<T, U>(iter: T) -> Result<Self, ArrowError>
+ where
+ T: Iterator<Item = Option<U>>,
+ U: AsRef<[u8]>,
+ {
+ Self::try_from_sparse_iter_with_size(iter, None)
+ }
+
+ pub fn try_from_sparse_iter_with_size<T, U>(
+ mut iter: T,
+ asserted_size: Option<i32>,
Review Comment:
I don't see why you need to distinguish between the two different sizes in
the implementation, it doesn't change if the size is determined by being passed
in or from the first non-null element. They must all be equal regardless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
