waynexia commented on issue #3777: URL: https://github.com/apache/arrow-datafusion/issues/3777#issuecomment-1311640870
>Also since the providers now may perform IO, this is a good opportunity to introduce error handling (e.g. make all methods return a Result). Good point, I agree 👍 >So I would propose to maybe split the modifiers from the actual provider traits? Like: This makes sense in some perspectives, but how would the proposed traits (`CatalogList` and `CatalogListWriter`) be used? I.e., which one should `SessionState` requires. Consider the access operations are now modeled together with modify operations, if we split the `CatalogList` then `SessionState` (or the upper level operations) may also need to be separated. For the situation "*not be able to modify the provider*" another way is to keep the definition as-is, and leave the detail to the implementor. If it (like a completely static catalog) can not do modification, it can return an error and fail this operation. But I'm not very familiar with other use cases like iceberg catalog, would like to hear more opinions (and thanks in advance). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
