alamb commented on code in PR #4189:
URL: https://github.com/apache/arrow-datafusion/pull/4189#discussion_r1020882994
##########
datafusion/common/src/scalar.rs:
##########
@@ -572,7 +572,12 @@ fn do_date_time_math(
scalar: &ScalarValue,
sign: i32,
) -> Result<NaiveDateTime> {
- let prior = NaiveDateTime::from_timestamp(secs, nsecs);
+ let prior = NaiveDateTime::from_timestamp_opt(secs, nsecs).ok_or_else(|| {
Review Comment:
I wonder if this is the same as mentioned by @waitingkuo on
https://github.com/apache/arrow-datafusion/pull/4156#issuecomment-1311270098
from @andre-cc-natzka 🤔
Maybe after merging up that PR with this fix we'll get a real error rather
than a panic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
