viirya commented on code in PR #3098:
URL: https://github.com/apache/arrow-rs/pull/3098#discussion_r1020943986
##########
arrow-schema/src/field.rs:
##########
@@ -333,8 +334,8 @@ impl Field {
// type id.
if self_type_id != field_type_id {
return Err(ArrowError::SchemaError(
- "Fail to merge schema Field due to
conflicting type ids in union datatype"
- .to_string(),
+ format!("Fail to merge schema field
because the self_type_id = {} does not equals field_type_id = {}",
Review Comment:
```suggestion
format!("Fail to merge schema field
because the self_type_id = {} does not equal field_type_id = {}",
```
##########
arrow-schema/src/field.rs:
##########
@@ -390,8 +391,8 @@ impl Field {
| DataType::Decimal256(_, _) => {
if self.data_type != from.data_type {
return Err(ArrowError::SchemaError(
- "Fail to merge schema Field due to conflicting
datatype"
- .to_string(),
+ format!("Fail to merge schema field because the from
data_type = {} does not equals {}",
Review Comment:
```suggestion
format!("Fail to merge schema field because the from
data_type = {} does not equal {}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
