wgtmac commented on PR #14191: URL: https://github.com/apache/arrow/pull/14191#issuecomment-1312941426
> @wgtmac Thanks for the review. I addressed your comments. Outstanding items: FastDifferentialCoding & testing Put where `values.null_count() > 0`. Thanks for addressing the comments! The overall change looks good to me. With regard to the testing of writes via arrow::Array, we can add them here: https://github.com/apache/arrow/blob/master/cpp/src/parquet/arrow/arrow_reader_writer_test.cc#L4406. @pitrou @wjones127 Can you please take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
