liukun4515 commented on code in PR #4149:
URL: https://github.com/apache/arrow-datafusion/pull/4149#discussion_r1021064844
##########
datafusion/optimizer/src/unwrap_cast_in_comparison.rs:
##########
@@ -639,12 +693,12 @@ mod tests {
// but the type of c6 is uint32
// the rewriter will not throw error and just return the original expr
let schema = expr_test_schema();
- let expr_input = cast(col("c6"), DataType::Int64).eq(lit(0i64));
+ let expr_input = cast(col("c6"), DataType::Float64).eq(lit(0f64));
Review Comment:
the comment of ```"c6 > 0" will be cast to `cast(c6 as int64) > 0``` should
be change to ```"c6 > 0"` will be cast to `cast(c6 as float64) > 0```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
