Ted-Jiang commented on code in PR #4200:
URL: https://github.com/apache/arrow-datafusion/pull/4200#discussion_r1021387680
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1105,6 +1149,18 @@ mod tests {
assert_eq!(simplify(expr_b), expected);
}
+ #[test]
+ fn test_simplify_and_not_self() {
+ // A AND !A if A is not nullable --> false
+ // !A AND A if A is not nullable --> false
+ let expr_a = col("c2_non_null").and(col("c2_non_null").not());
+ let expr_b = col("c2_non_null").not().and(col("c2_non_null"));
Review Comment:
Without this change, these test fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
