askoa commented on code in PR #3103:
URL: https://github.com/apache/arrow-rs/pull/3103#discussion_r1021424138
##########
parquet/src/file/metadata.rs:
##########
@@ -353,6 +377,15 @@ impl RowGroupMetaDataBuilder {
self
}
+ /// Sets the sorting order for columns
+ pub fn set_sorting_columns(
+ mut self,
+ value: Option<Vec<SortingColumnMetaData>>,
+ ) -> Self {
+ self.sorting_columns = value;
Review Comment:
I got a reverse review before. The reason given by the reviewer was that if
we remove `Option` from signature then the function cannot be used to set
`None` for this field. I am going to keep this as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
