pitrou commented on code in PR #14632:
URL: https://github.com/apache/arrow/pull/14632#discussion_r1021480204
##########
cpp/src/arrow/table.h:
##########
@@ -286,7 +286,18 @@ struct ARROW_EXPORT ConcatenateTablesOptions {
static ConcatenateTablesOptions Defaults() { return {}; }
};
-/// \brief Construct table from multiple input tables.
+/// \brief Construct a new table from multiple input tables. Underlying column
arrays
+/// are concatenated without copying except in case of schema missmatch in
which case
+/// columns will be cast to promoted types which will cause a copy. Tables
will be
+/// concatenated in order they are provided in and order of rows within tables
will be
+/// preserved.
+///
+/// \param[in] tables a std::vector of Tables to be concatenated
+/// \param[in] options specify how to unify schema of input tables
+/// \param[in] memory_pool MemoryPool to be used if null-filled arrays need to
+/// be created.
Review Comment:
```suggestion
/// \param[in] memory_pool MemoryPool to be used if null-filled arrays need
to
/// be created or if existing column chunks need to endure type conversion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]