milesgranger commented on code in PR #14601:
URL: https://github.com/apache/arrow/pull/14601#discussion_r1022552474
##########
cpp/src/arrow/filesystem/s3_internal.h:
##########
@@ -158,6 +170,13 @@ Status ErrorToStatus(const std::string& prefix, const
std::string& operation,
if (error_type == Aws::S3::S3Errors::UNKNOWN) {
ss << " (HTTP status " << static_cast<int>(error.GetResponseCode()) << ")";
}
+ const auto maybe_region = BucketRegionFromError(error);
+ if (maybe_region.has_value() && region.has_value()) {
Review Comment:
https://github.com/apache/arrow/pull/14601/commits/d1b6471570d7fc1f82ca1a885c8d96ad664f528f
##########
cpp/src/arrow/filesystem/s3_internal.h:
##########
@@ -158,6 +170,13 @@ Status ErrorToStatus(const std::string& prefix, const
std::string& operation,
if (error_type == Aws::S3::S3Errors::UNKNOWN) {
ss << " (HTTP status " << static_cast<int>(error.GetResponseCode()) << ")";
}
+ const auto maybe_region = BucketRegionFromError(error);
+ if (maybe_region.has_value() && region.has_value()) {
+ if (maybe_region.value() != region.value()) {
+ ss << " Looks like the configured region is '" + region.value() +
Review Comment:
https://github.com/apache/arrow/pull/14601/commits/6c476ca1c386d215d68375b9ef33c0475aea9292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
