alamb commented on code in PR #4186:
URL: https://github.com/apache/arrow-datafusion/pull/4186#discussion_r1022661156
##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -917,19 +917,19 @@ async fn test_interval_expressions() -> Result<()> {
);
test_expression!(
"interval '0.499 day'",
- "0 years 0 mons 0 days 11 hours 58 mins 33.596 secs"
+ "0 years 0 mons 0 days 11 hours 58 mins 33.600 secs"
);
test_expression!(
"interval '0.4999 day'",
- "0 years 0 mons 0 days 11 hours 59 mins 51.364 secs"
+ "0 years 0 mons 0 days 11 hours 59 mins 51.360 secs"
);
test_expression!(
"interval '0.49999 day'",
"0 years 0 mons 0 days 11 hours 59 mins 59.136 secs"
);
test_expression!(
"interval '0.49999999999 day'",
- "0 years 0 mons 0 days 12 hours 0 mins 0.00 secs"
+ "0 years 0 mons 0 days 11 hours 59 mins 59.999999136 secs"
);
test_expression!(
Review Comment:
We can also add test cases that are marked as `#[should_fail]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
