jorisvandenbossche commented on code in PR #14631:
URL: https://github.com/apache/arrow/pull/14631#discussion_r1022730083
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -1071,14 +1071,6 @@ def test_python_datetime_with_timezone_tzinfo(self):
pytz = pytest.importorskip("pytz")
from datetime import timezone
- if Version(pd.__version__) > Version("0.25.0"):
- # older pandas versions fail on datetime.timezone.utc (as in input)
- # vs pytz.UTC (as in result)
- values = [datetime(2018, 1, 1, 12, 23, 45, tzinfo=timezone.utc)]
- # also test with index to ensure both paths roundtrip (ARROW-9962)
- df = pd.DataFrame({'datetime': values}, index=values)
- _check_pandas_roundtrip(df, preserve_index=True)
Review Comment:
This can be kept, but without the comment?
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -2860,9 +2852,8 @@ def _fully_loaded_dataframe_example():
9: pd.period_range('2013', periods=10, freq='M')
}
- if Version(pd.__version__) >= Version('0.21'):
- # There is an issue with pickling IntervalIndex in pandas 0.20.x
- data[10] = pd.interval_range(start=1, freq=1, periods=10)
+ # There is an issue with pickling IntervalIndex in pandas 0.20.x
+ data[10] = pd.interval_range(start=1, freq=1, periods=10)
Review Comment:
I think you can remove the comment as well (that was only relevant when
putting it behind the `if` version check).
And then you can also move that inside the dict above (`10:
pd.internval_range ...`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
