andre-cc-natzka commented on code in PR #4156: URL: https://github.com/apache/arrow-datafusion/pull/4156#discussion_r1022965056
########## datafusion/core/src/physical_plan/hash_utils.rs: ########## @@ -0,0 +1,830 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: Hello @alamb! I have been looking into the merges and I think that is exactly what happened. Indeed, this file was present in version 13, but it is no longer there. I had to change `/datafusion/core/src/physical_plan/joins/hash_join.rs` and I ended up modifying `datafusion/core/src/physical_plan/hash_utils.rs` as well. Then I wasn't sure if this file had been eliminated or not, and while solving the merge conflicts I thought it had not been, but I was wrong. It seems clear to me now that this file has to be removed and everything will be solved. But maybe I am missing something? I will push the new version without this file, please let me know what you think. And thank you very much for your words and for going through my changes! We are happy to cooperate with you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
