timvw commented on code in PR #4227:
URL: https://github.com/apache/arrow-datafusion/pull/4227#discussion_r1023245036


##########
datafusion/core/src/execution/context.rs:
##########
@@ -2296,8 +2235,8 @@ mod tests {
         let url = format!("file://{}", path.display());
 
         let mut table_factories: HashMap<String, Arc<dyn 
TableProviderFactory>> =
-            HashMap::new();
-        let factory = Arc::new(ListingTableFactory::new(FileType::CSV));
+            RuntimeConfig::default().table_factories;
+        let factory = Arc::new(ListingTableFactory::new());
         table_factories.insert("test".to_string(), factory);
         let rt_cfg = 
RuntimeConfig::new().with_table_factories(table_factories);

Review Comment:
   Probably want an easier way to add/register additional factories (instead of 
re-providing the entire collection), similar to object_store_registry



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to