viirya commented on PR #3115: URL: https://github.com/apache/arrow-rs/pull/3115#issuecomment-1316355302
> This is really exciting, left some further comments. I had envisaged that `into_builder` and related APIs would keep the existing values. Effectively they are a way to go from the immutable `Array` representation back to the mutable `Builder` representation? Yes, they can. `unary_mut` demonstrates it. You can give it a `op` which returns original values for all or partial indexes to keep the existing values. For `into_builder`, `PrimitiveBuilder` currently doesn't offer the capacity to advance without setting its value buffer. For keeping the existing values, we may need to add an API for advancing without changing buffer values. Thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
