viirya commented on code in PR #3115:
URL: https://github.com/apache/arrow-rs/pull/3115#discussion_r1023641615
##########
arrow-array/src/builder/null_buffer_builder.rs:
##########
@@ -42,6 +42,16 @@ impl NullBufferBuilder {
}
}
+ /// Creates a new builder from a `MutableBuffer`.
+ pub fn new_from_buffer(buffer: MutableBuffer, len: usize, capacity: usize)
-> Self {
Review Comment:
I think `capacity` should not be passed in. Simply take `buffer.len() * 8`
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
