rok commented on code in PR #14434:
URL: https://github.com/apache/arrow/pull/14434#discussion_r1024323342
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -313,7 +330,18 @@ TEST(FunctionMapping, ValidCases) {
{"abc", "def"},
{utf8(), utf8()},
"abcdef",
- utf8()}};
+ utf8()},
+ {{kSubstraitLogarithmicFunctionsUri, "ln"}, {"1"}, {int8()}, "0",
float64()},
+ {{kSubstraitLogarithmicFunctionsUri, "log10"}, {"1"}, {int8()}, "0",
float64()},
+ {{kSubstraitLogarithmicFunctionsUri, "log2"}, {"2"}, {int8()}, "1",
float64()},
+ {{kSubstraitLogarithmicFunctionsUri, "log1p"}, {"0"}, {int8()}, "0",
float64()},
+ {{kSubstraitLogarithmicFunctionsUri, "logb"},
Review Comment:
Agreed. I've changed the `exp(0)`-like cases to be more discriminating.
Also note the comment above:
```
// These are not meant to be an exhaustive test of Substrait
// conformance. Instead, we should test just enough to ensure
// we are mapping to the correct function
TEST(FunctionMapping, ValidCases) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
