jorisvandenbossche commented on a change in pull request #8294:
URL: https://github.com/apache/arrow/pull/8294#discussion_r504113404
##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -142,6 +142,20 @@ Result<Datum> MinMax(const Datum& value,
const MinMaxOptions& options = MinMaxOptions::Defaults(),
ExecContext* ctx = NULLPTR);
+/// \brief Test whether any element in a boolean array evaluates to true.
+///
+/// This function returns true if any of the elements in the array evaluates
+/// to true and false otherwise. Null values are taken to evaluate to false.
Review comment:
Ah, yes, you're correct that for this PR there is not yet a difference:
you are only dealing with `any`, and it's only for `all` that there is a
difference between "skipping nulls" and "treating nulls as False"
So I would indeed update the docstring to simply state that nulls are
skipped.
For your example about `all` (I assume the code was meant to use `all` and
not `any` ?), for the last line about Kleene logic I expect a return value of
`null` (as the `ǹull` in the values can be both True or False, meaning that the
result can be True of False, meaning it is unknown)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
