rtpsw commented on code in PR #14352:
URL: https://github.com/apache/arrow/pull/14352#discussion_r1027283787
##########
cpp/src/arrow/compute/exec/aggregate_node.cc:
##########
@@ -81,10 +152,22 @@ class ScalarAggregateNode : public ExecNode {
const auto& aggregate_options = checked_cast<const
AggregateNodeOptions&>(options);
auto aggregates = aggregate_options.aggregates;
+ const auto& segment_keys = aggregate_options.segment_keys;
const auto& input_schema = *inputs[0]->output_schema();
auto exec_ctx = plan->exec_context();
+ std::vector<int> segment_field_ids(segment_keys.size());
+ std::vector<TypeHolder> segment_key_types(segment_keys.size());
+ for (size_t i = 0; i < segment_keys.size(); i++) {
+ ARROW_ASSIGN_OR_RAISE(auto match, segment_keys[i].FindOne(input_schema));
+ segment_field_ids[i] = match[0];
Review Comment:
https://issues.apache.org/jira/browse/ARROW-18369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
