tustvold commented on code in PR #3139:
URL: https://github.com/apache/arrow-rs/pull/3139#discussion_r1028295853
##########
arrow-cast/src/cast.rs:
##########
@@ -1981,9 +2006,23 @@ fn cast_decimal_to_decimal_safe<const BYTE_WIDTH1:
usize, const BYTE_WIDTH2: usi
} else {
let array =
array.as_any().downcast_ref::<Decimal256Array>().unwrap();
let div = i256::from_i128(div);
+ let half = div / i256::from_i128(2);
+ // TODO: it's better to implement the neg
Review Comment:
https://github.com/apache/arrow-rs/pull/3151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
