retikulum opened a new pull request, #4313:
URL: https://github.com/apache/arrow-datafusion/pull/4313
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
This is discussed in #3152.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This is the new PR of improving error handling for downcasting. In #4261 we
found out that there is a `downcast_value!` macro which also covers our casting
functions. Implementing `as_xxx_array` function with `downcast_value!` is
nearly decided for now for future PRs. This PR is small compared to last two PR
because I want to hear your feedback about if my implementation is
correct/desired?
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Refactor previous casting functions. Old function:
```rust
pub fn as_int32_array(array: &dyn Array) -> Result<&Int32Array,
DataFusionError> {
array.as_any().downcast_ref::<Int32Array>().ok_or_else(|| {
DataFusionError::Internal(format!(
"Expected a Int32Array, got: {}",
array.data_type()
))
})
```
New function:
```rust
pub fn as_int32_array(array: &dyn Array) -> Result<&Int32Array,
DataFusionError> {
Ok(downcast_value!(array, Int32Array))
}
```
- Refactor `ListArray` downcasting parts where following lines are used:
```rust
as_any().downcast_ref::<ListArray>().unwrap()
```
# Are these changes tested?
These changes passed related tests.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
