jackwener commented on code in PR #4316:
URL: https://github.com/apache/arrow-datafusion/pull/4316#discussion_r1028816313


##########
datafusion/core/src/physical_optimizer/optimizer.rs:
##########
@@ -36,4 +36,10 @@ pub trait PhysicalOptimizerRule {
 
     /// A human readable name for this optimizer rule
     fn name(&self) -> &str;
+
+    /// A flag to indicate whether the physical planner should valid the rule 
will not
+    /// change the schema of the plan after the rewriting.
+    /// Some of the optimization rules might change the nullable properties of 
the schema
+    /// and should disable the schema check.
+    fn schema_check(&self) -> bool;

Review Comment:
   👍



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to