jorisvandenbossche commented on code in PR #14656: URL: https://github.com/apache/arrow/pull/14656#discussion_r1029176687
########## python/pyarrow/tests/test_cpp_internals.py: ########## @@ -31,3 +34,17 @@ def wrapper(case=case): inject_cpp_tests(globals()) + + +def test_pyarrow_include(): + # We need to make sure that pyarrow/include is always + # created. Either with PyArrow C++ header files or with + # Arrow C++ and PyArrow C++ header files together + + source = os.path.dirname(os.path.abspath(__file__)) + pyarrow_dir = os.path.abspath(pjoin(source, '..')) Review Comment: But so about @kou's original comment, I think doing `os.path.dirname(source)` also works because if `source` is already a directory, `dirname` gives the parent directory. Now personally I find `..` more explicit to read that it goes one level up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
