Jedi18 commented on PR #14369: URL: https://github.com/apache/arrow/pull/14369#issuecomment-1323732316
@pitrou Sorry for the late reply, just saw the comments now > Can you first tackle just the C++ side and write tests on that side? Sure I'll do that first. There was no straightforward way to test it on the C++ side hence the python tests. I'll look into it a bit more and see how I can test it in the unit tests. > Did you actually measure performance? I expect this to be slower that the current RecordBatch and Table sorting. I did not, and yeah that's one of the reasons for wanting seperate PRs for those so I can at the very least mirror the current implementation and performance. Are you saying we should get those done first and measure it before we think about merging this in case it turns out to be slower than the current implementation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
