[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4318: Refine Err propagation and avoid unwrap in transform closures

[GitBox]

alamb commented on code in PR #4318:
URL: https://github.com/apache/arrow-datafusion/pull/4318#discussion_r1029869155


##########
datafusion/core/src/physical_plan/rewrite.rs:
##########
@@ -78,7 +78,7 @@ pub trait TreeNodeRewritable: Clone {
     /// The default tree traversal direction is transform_up(Postorder 
Traversal).
     fn transform<F>(self, op: &F) -> Result<Self>
     where
-        F: Fn(Self) -> Option<Self>,
+        F: Fn(Self) -> Result<Option<Self>>,

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org