save-buffer commented on code in PR #14227: URL: https://github.com/apache/arrow/pull/14227#discussion_r1029907899
########## cpp/src/arrow/compute/exec/query_context.h: ########## @@ -0,0 +1,165 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/exec.h" +#include "arrow/compute/exec/task_util.h" +#include "arrow/compute/exec/util.h" +#include "arrow/io/interfaces.h" +#include "arrow/util/async_util.h" + +#pragma once + +namespace arrow { +namespace internal { +class CpuInfo; +} + +using io::IOContext; +namespace compute { +struct ARROW_EXPORT QueryOptions { + QueryOptions(); + // 0 means unlimited + size_t max_memory_bytes; + + /// \brief Should the plan use a legacy batching strategy + /// + /// This is currently in place only to support the Scanner::ToTable + /// method. This method relies on batch indices from the scanner + /// remaining consistent. This is impractical in the ExecPlan which + /// might slice batches as needed (e.g. for a join) + /// + /// However, it still works for simple plans and this is the only way + /// we have at the moment for maintaining implicit order. + bool use_legacy_batching; +}; + +class ARROW_EXPORT QueryContext { Review Comment: I'd be fine waiting before writing docs, I think a lot of the design in Acero is still in flux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
