ljishen commented on code in PR #14681: URL: https://github.com/apache/arrow/pull/14681#discussion_r1030009256
########## cpp/src/arrow/engine/substrait/expression_internal.cc: ########## @@ -19,16 +19,44 @@ #include "arrow/engine/substrait/expression_internal.h" +#include <stdint.h> +#include <algorithm> +#include <array> +#include <cstring> +#include <functional> #include <memory> +#include <optional> +#include <string> +#include <string_view> +#include <type_traits> #include <utility> - -#include "arrow/builder.h" Review Comment: I used the `build-support/iwyu/iwyu.sh` to generate these includes. I've updated the code to use `type_fwd.h` files as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
