alamb commented on code in PR #3174:
URL: https://github.com/apache/arrow-rs/pull/3174#discussion_r1030755586
##########
arrow/src/row/mod.rs:
##########
@@ -465,14 +470,15 @@ impl RowConverter {
where
I: IntoIterator<Item = Row<'a>>,
{
+ let mut validate_utf8 = false;
let mut rows: Vec<_> = rows
.into_iter()
.map(|row| {
assert!(
- Arc::ptr_eq(row.fields, &self.fields),
+ Arc::ptr_eq(&row.config.fields, &self.fields),
"rows were not produced by this RowConverter"
);
-
+ validate_utf8 |= row.config.validate_utf8;
Review Comment:
But wound't this code effectively validate all rows in this case, even those
that we know haven't been spilled? Maybe I misread it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
