pitrou commented on a change in pull request #8457:
URL: https://github.com/apache/arrow/pull/8457#discussion_r505568854
##########
File path: python/pyarrow/compute.py
##########
@@ -47,34 +47,60 @@
import pyarrow as pa
+def _get_arg_names(func):
+ arg_names = func._doc.arg_names
+ if not arg_names:
+ if func.arity == 1:
+ arg_names = ["arg"]
+ elif func.arity == 2:
+ arg_names = ["left", "right"]
+ else:
+ raise NotImplementedError(
+ "unsupported arity: {}".format(func.arity))
Review comment:
Since this is only a fallback for functions which don't defined a
documentation, I agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
