viirya commented on code in PR #3155:
URL: https://github.com/apache/arrow-rs/pull/3155#discussion_r1031292671
##########
arrow-array/src/arithmetic.rs:
##########
@@ -45,61 +45,83 @@ pub trait ArrowNativeTypeOp: ArrowNativeType {
/// The multiplicative identity
const ONE: Self;
+ /// A checked add operation
fn add_checked(self, rhs: Self) -> Result<Self, ArrowError>;
+ /// A wrapping add operation
fn add_wrapping(self, rhs: Self) -> Self;
+ /// A checked subtract operation
fn sub_checked(self, rhs: Self) -> Result<Self, ArrowError>;
+ /// A wrapping subtract operation
Review Comment:
```suggestion
/// Wrapping subtraction operation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]